DrHanLim / EzColocalization

GNU General Public License v3.0
10 stars 2 forks source link

ROI manager malfunction #5

Closed lauraczd closed 4 years ago

lauraczd commented 4 years ago

Dear authors,

sorry to disturb but I have been using the last version of EZColocalisation to analise stacks of pre-aligned SIM data in the last few days and I am having trouble using the ROI selection function.

I select the ROIs manually, add them to the ROI manager as normal (and as indicated in your Sci Rep 2018 paper), and then select ROI manager as cell idenitication input image and Manual as cell identification input method in the box below the alignment method. Finally I click the ROI checkbox in the Analysis tab as method for cell identification function.

This invariably causes the analysis to fall over with the error log below. **Errors** (ezcol.cell.CellDataProcessor.mask2data(CellDataProcessor.java:84)): No cell is found based on the selected filters. (ezcol.main.AnalysisOperator.applyToStack(AnalysisOperator.java:420)): Error in cell data processor on slice 1 (ezcol.main.AnalysisOperator.applyToStack(AnalysisOperator.java:469)): Error in calculating metrics on slice 1 (ezcol.main.AnalysisOperator.applyToStack(AnalysisOperator.java:476)): Error in calculating mTOS on slice 1 (ezcol.main.AnalysisOperator.finishStack(AnalysisOperator.java:576)): No result to be printed ezcol.main.AnalysisOperator(ezcol.main.AnalysisOperator.finishStack(AnalysisOperator.java:801)): Output ResultsTable is empty

END ERROR LOG

Initially I though it might have been an issue of the stacks being too big and my machine being too weak to handle the dataset (even though it has 16GB of memory and an Intel i7 8th gen processor), however I have managed to replicate the same problem also with single 16-bit .tiff images extracted from the stack, as long as more than 3 non-overlapping areas are selected. This goes contrary to what shown in the Sci Rep 2018 paper, in figures 7 and 8, where the workflow is implied to work with >3 ROIs.

Could you please look into this and, if this is a matter of machine requisites, could you please indicate what are the minimal requisites necessary for a 2-colour colocalisation workflow using ROI on pre-aligned 16-bit .tiff stacks?

Regards,

Laura C Zanetti Domingues

lauraczd commented 4 years ago

Dear authors,

I found another error when using the ROI manager. I selected two ROIs (marked 1 and 2 on the screenshot) and run the plugin with the parameters indicated in the screenshot, and the EzColocalisation plugin actually analysed the tiny area marked on the green cells on the right of the screenshot, which is between the two areas I asked it to analyse.

This might have happened because watershed segmentation was accidentally selected in the filters tab, even though I have no idea why it would have selected a third area at the boundary of the selected two (which were non-overlapping).

Best,

Laura C Zanetti Domingues EzColocalisationError_ROImanager-Subtract

shenghuanjie commented 4 years ago

@Sereq Hi Laura, sorry for the late response. Thank you for reaching out and reporting the issue you encountered. We are investigating this problem. Can you attach your sample images and the selected ROIs or send it to shenghuanjie@berkeley.edu? You can save your ROIs within the ROImanger at More>>Save. Make sure you deselect or select all ROIs so they are saved together as a zip file. In addition, it would be very helpful if you could share your settings on the other tabs as well. We will try to fix or advice on this issue ASAP.

westonstauffer commented 4 years ago

@Sereq Hi Laura,

Thank you for letting us know about your issues, and we are happy to help! For your first issue, we were able to recreate it and found that it occurred when cell filters were removing all cells from analysis. Can you confirm that you aren’t using a cell filter (on the “Cell Filters” tab) which is too narrow to select any of your ROIs? In other words, have you entered any ranges within that panel, which may exclude your ROIs?

For your second issue, we weren’t able to recreate a similar result. Would you be willing to share the example images you gave, along with inputs across all tabs so we can work on amending it? If you are willing, you can email them to myself (westonstauffer@berkeley.edu), or to shenghuanjie@berkeley.edu. Please let us know if the first fix works for you too.

Sincerely, Weston

lauraczd commented 4 years ago

Hi folks,

thanks for replying. I have had another instance of no cells being found even with ROI selected and no filters selected. I am attaching all material, so you can have a check. I suspect it didn't handle the large area that well, because when I reduced it to two cells worth instead of three, it worked fine. All cell filters are left as default, 0-Infinite, so there is no way they can be rejecting my admittedly crappy cells. I will email you the ROI file, as it's not letting me attach it. T_T

I will try to replicate the other issue, but TBH I think it was a bug caused by having accidentally selected watershed filtering in the cell filter tab. All other options in that tab were left as default, like I always do.

Best,

Laura

Errortest1 Errortest2 Cbl_test EGFR_test EzColocalization errors_20190926.txt

shenghuanjie commented 4 years ago

@Sereq I'm able to reproduce the error you mentioned. Sorry for the inconvenience brought by this issue. It was introduced in 1.1.0. By default, EzColocalization tries to automatically determine the background versus the objects. In your case, your object is bigger than the background so EzColocalization thought your object was the background. We will try to fix it. As a temporary work-around for now, you can go to the EzColocalization menu. Settings -> Parameters Check ONLY the following box: Use Manual Background Settings Below. It should do the job. In the future release, we will not try to automatically identify background versus foreground if ROI manager is used.

On the other hand, I don't understand your issue about the watershed option.

shenghuanjie commented 4 years ago

This issue has been fixed in 1.1.3 EzColocalization will NOT attempt to automatically detect light/dark background in the cell identification channel if ROI manager is used.

lauraczd commented 4 years ago

Dear Dr Lim,

Thanks a lot for the fix. I will update the software on Monday.

Have a lovely weekend,

Laura C Zanetti Domingues

Il Sab 5 Ott 2019 02:36 Huanjie Sheng notifications@github.com ha scritto:

This issue has been fixed in 1.1.3 EzColocalization will NOT attempt to automatically detect light/dark background in the cell identification channel if ROI manager is used.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DrHanLim/EzColocalization/issues/5?email_source=notifications&email_token=AGLDXB4UFL3E4HA4GL2YOMDQM7VTLA5CNFSM4IX6HIUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANHOBI#issuecomment-538605317, or mute the thread https://github.com/notifications/unsubscribe-auth/AGLDXBYIWGW75ZCJWEURKO3QM7VTLANCNFSM4IX6HIUA .

shenghuanjie commented 4 years ago

@Sereq I just pushed the update to ImageJ update site and drafted a new release in this github repository. You can choose either way to update the plugin. Please let us know if any other issue develops and we are always happy to help. I will go ahead and close this issue.