search

DrHenchman / uhc-pack

A datapack for Minecraft Java Edition for running Ultra Hardcore (UHC) tournaments
GNU Affero General Public License v3.0
23 stars 5 forks source link

You can select the number of teams as 1 but randomizing requires at least 2 teams #74

Closed rdroog closed 3 years ago

rdroog commented 3 years ago

Describe the bug If you want to start a practice game with only 1 team, randomizing teams won't work - an error is produced. No other setting can be successfully changed anymore.

To Reproduce

  1. Create new UHC world
  2. Set teams to only 1 team
  3. Randomize teams

Result: error occurs, team is not randomized, no other settings can be changed anymore.

Expected behavior Error doesn't occur, other settings are still changeable, everyone is in the same team.

Environment (please complete the following information):

DrHenchman commented 3 years ago

If you are testing a UHC by yourself (you are the only player in the world) you can just click start, you don't need to put yourself into a team.

DrHenchman commented 3 years ago

The preferred fix is to modify https://github.com/DrHenchman/uhc-pack/blob/master/data/uhc_pack/functions/lobby/update_options.mcfunction#L35 to prevent setting the number of teams to 1.

DrHenchman commented 3 years ago

Fixed in v0.26