search

DrHyde / perl-modules-Number-Phone

Number::Phone and friends
24 stars 32 forks source link

Fix ->country for grand children subclasses #1

Closed dolmen closed 13 years ago

dolmen commented 13 years ago

Here is a patch for fixing the country() method for grand children of Number::Phone. I encountered the problem when creating Number::Phone::FR::Full which is a subclass of Number::Phone::FR: ->country() was not working as expected in Number::Phone::FR::Full (not returning 'FR').

The first commit is the failing test. The second commit is the fix.

DrHyde commented 13 years ago

On Tue, Aug 02, 2011 at 03:59:33PM -0700, dolmen wrote:

Here is a patch for fixing the country() method for grand children of Number::Phone. I encountered the problem when creating Number::Phone::FR::Full which is a subclass of Number::Phone::FR: ->country() was not working as expected in Number::Phone::FR::Full (not returning 'FR').

Thanks, released as version 1.8005.

David Cantrell | Official London Perl Mongers Bad Influence

Irregular English: you have anecdotes; they have data; I have proof

DrHyde commented 10 years ago

I just had a mailing list created for Number::Phone users: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/number-phone