search

DrHyde / perl-modules-Number-Phone

Number::Phone and friends
24 stars 31 forks source link

Do not destroy `@ARGV` while searching for `--without_uk`. #106

Closed bleargh45 closed 2 years ago

bleargh45 commented 2 years ago

When we destroy @ARGV by shifting the values off, we lose any command line arguments that they user may have provided while running perl Makefile.PL (e.g. INSTALLDIRS=...).

So, rather than shifting the arguments off to search for our custom --without_uk argument, just iterate over @ARGV.

DrHyde commented 2 years ago

Ahhhh, this would explain https://github.com/DrHyde/perl-modules-Number-Phone/issues/105, which I closed thinking "not my fault guv"! @vicbitone, does this fix your issue?

bleargh45 commented 2 years ago

Ahhhh, this would explain #105, which I closed thinking "not my fault guv"! @vicbitone, does this fix your issue?

Ah-ha! That's precisely the type of issue that I was having, so yes, I suspect that this should fix his issue. Fingers crossed!

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 99.538% when pulling 935518b3bba5c383e9f87dea6478e42009bdecf5 on bleargh45:bleargh.fix-makefile-pl into a95f3a3a8fcec87a5f7c22a2cac0cefbc25343b0 on DrHyde:master.

DrHyde commented 2 years ago

Thanks, this will be in the next quarterly release.

DrHyde commented 2 years ago

Released