search

DrHyde / perl-modules-Number-Phone

Number::Phone and friends
24 stars 32 forks source link

Add unit tests for Austrian (+43) numbers #46

Closed gpoul closed 9 years ago

DrHyde commented 9 years ago

Is +43 828 20200 valid? According to libphonenumber it's one digit short - +43 828 followed by six digits, however, would be "shared cost", so "specialrate" in Number::Phone terms. See https://github.com/googlei18n/libphonenumber/blob/master/resources/PhoneNumberMetadata.xml#L1533

If libphonenumber is wrong then I can submit an update to them. In the mean time, however, I've commented out the tests for that number.

DrHyde commented 9 years ago

Hmm, OK, I found a reference on RTR's website that says it's valid. Bug report submitted upstream :-)

gpoul commented 9 years ago

Yes, I just verified that +43 828 20200 is indeed a valid number. It was used for a text messaging fo a mobile parking service.

Thanks for fixing the special rates. I wasn't sure what the definition was for those. For +43 900 numbers it is pretty clear, but for +43 810 I wasn't sure.