search

DrHyde / perl-modules-Number-Phone

Number::Phone and friends
24 stars 31 forks source link

Data Updates Due for MSISDNs in Malaysia #97

Closed atancasis closed 4 years ago

atancasis commented 4 years ago

Google's libphonenumber had this recent update just a couple of days ago on May 6, wherein this addendum was finally fixed here among (potentially) others.

To illustrate:

http://libphonenumber.appspot.com/phonenumberparser?number=6001172332796&country=MY

vs.

❯ perl -MNumber::Phone -E 'say $Number::Phone::VERSION; my $np = Number::Phone->new("6001172332796"); say $np->is_valid'
3.6003
Can't call method "is_valid" on an undefined value at -e line 1.

Fixing this might just require a rebuild of the library after pulling in the latest data. If an official release can be made following that, that would be much appreciated. Thanks!

DrHyde commented 4 years ago

Thanks. That should be +6011 in N::P, not 60011, but even so, I'll fix it to recognise the new range - you were right, it was just a case of re-running the build script. I'll push out a new release shortly.

I generally don't track all libphonenumber releases immediately, instead I do data updates every three months. The documentation on the update policy was not perhaps clear enough, so I've also updated that.

DrHyde commented 4 years ago

Fixed in 3.6004, which is currently on its way to the CPAN

atancasis commented 4 years ago

awesome, thank you SO MUCH @DrHyde, much appreciated!! 🙏