DrInfy / sharpy-sc2

Python framework for rapid development of Starcraft 2 AI bots
MIT License
69 stars 28 forks source link

Algorithm argument for DBSCAN #109

Closed raspersc2 closed 1 year ago

raspersc2 commented 1 year ago

The default algorithm option for DBSCAN in sklearn is auto https://scikit-learn.org/stable/modules/generated/sklearn.cluster.DBSCAN.html

Turns out this has major performance issues on linux on the latest sklearn versions since auto makes some bad choices. There should be a noticeable improvement in step times on aiarena ladder

The algorithm choice of kd_tree has been well tested in Eris (despite not using sharpy it does use this very same function), and fairly certain Zoe has used this option for some time too.

DrInfy commented 1 year ago

Looks fine.