DrJavaAtRice / drjava

Branches for integration and releases
20 stars 28 forks source link

suggested fixes by iCR, OpenRefactory, Inc. #16

Open openrefactory opened 4 years ago

openrefactory commented 4 years ago

OpenRefactory introduces fixers, that automatically fix safety, security, reliability and compliance issues. We ran OpenRefactory's Intelligent Code Repair (iCR) analysis engine on your code. We are reporting a few sample fixes that were generated. The goal of the this fix is to resolve Improper Method Call, Zero Division Check and Weak Library Usage.

Improper Method Call Fix: In file: RemoteControlServer.java, class: RCServerThread, method:finalize overrides the method defined in its superclass. But the implementation does not refer to the overridden method . iCR suggested changes in 1 files to resolve the problem.

In file: DefinitionsDocument.java, class:DefinitionsDocument, method:finalize overrides the method defined in its superclass. But the implementation does not refer to the overridden method . iCR suggested changes in 1 files to resolve the problem.

The fix addresses CWE 568.

Zero Division Check Fix: In file: ExpressionEvaluator.java, class:ExpressionEvaluator, method: value, there are potential Division By Zero errors while running. iCR suggested changes in 1 files to resolve the problem.

The fix addresses CWE 369.

Weak Library Usage Fix: In file: LogTest.java, class: LogTest, method: testConcurrentWrites uses Random object but it may not be truly random. It should be replaced with SecureRandom. . iCR suggested changes in 1 files to resolve the problem.