DrKain / subclean

A cross-platform CLI tool and node module to remove advertising from subtitles. Supports Bazarr and bulk cleaning!
MIT License
54 stars 5 forks source link

[Feature Request] Delete empty nodes #12

Closed DrKain closed 2 years ago

DrKain commented 2 years ago

Right now subclean will leave empty nodes instead of deleting them. The empty text nodes do not display for any client, but at least one person notified me it bothered them. This was done for two reason:

  1. Empty nodes show where an ad was removed
  2. Modifying the node structure risks breaking the file more than simply blanking the text

The ideal outcome would be passing a parameter to enable the deletion of empty nodes instead of blanking the text. This should be disabled by default.

This issue is very low priority and I likely will not bother unless there's a higher demand. If this is something you want please leave a reaction or comment.
Alternatively, if you want to add this feature yourself feel free to create a PR.