search

DrKain / subclean

A cross-platform CLI tool and node module to remove advertising from subtitles. Supports Bazarr and bulk cleaning!
MIT License
54 stars 5 forks source link

[Bug] Unidentified ad example #14

Closed Hebo closed 2 years ago

Hebo commented 2 years ago

Hey, great package, been working really well. Saw an ad that didn't get picked up just now:

46
00:01:58,900 --> 00:02:04,974
Watch Movies, TV Series & Live Sports
www.admitme.app

Anecdotally, I see a lot of ads in a similar format, wonder if it's worth having a regex to detect the format of URLs, as they're likely an ad (or at least .app)?

DrKain commented 2 years ago

Hi, thanks for reporting. I'll add admitme.app to the filters.

A filter for all URLs would need to be optional, seeing as there are plenty of instances where a character is taking about a certain website or domain that may not be an ad