DrKain / subclean

A cross-platform CLI tool and node module to remove advertising from subtitles. Supports Bazarr and bulk cleaning!
MIT License
54 stars 5 forks source link

enforce case sensitivity for regex #26

Open Irek7 opened 1 year ago

Irek7 commented 1 year ago

I tried to enforce case sensitivity but [S] and [s] seems to be equal for the engine. Is there any other way I can enforce that?

DrKain commented 1 year ago

Can you please provide an example where this would benefit from case-sensitive filters?
Lowercase matching was used because many providers were using camel case or full caps, lowercase matching ensured the filters would match even with odd capitalization.

Irek7 commented 1 year ago

for example, someone uses quite generic name RufuS. Simple one line with it. But I can imagine that there are some ppl/places/stuff named like Rufus.

DrKain commented 1 year ago

Generally those would be avoided, at the very least I can look into making the user filters case-sensitive but not the main ones.

Irek7 commented 1 year ago

Best would be switch at the end of filter: „/RufuS/i”

Thanks.