DrKain / subclean

A cross-platform CLI tool and node module to remove advertising from subtitles. Supports Bazarr and bulk cleaning!
MIT License
55 stars 5 forks source link

[Bug] Custom filter gets deleted on update #30

Closed Obscurax closed 1 year ago

Obscurax commented 1 year ago

I have some custom filter for dutch subtitles. These are free to use for nl-main.json.

[
  "tvpiraat",
  "/1 jaar Live TV/",
  "/1jaar Live TV/",
  "/vertrouwd Live Tv adres/",
  "/Simply ReleaseS Toppers/",
  "/QoQ/",
  "/ondertitel.com/",
  "/1 JAAR Familie IPTV/"
]

Problem is the custom filter gets deleted on an update.

.\subclean.exe --update
[Info] Received language codes:
[Info] Filter download queue: main,users,custom
[Info] Updated filter: main
[Info] Updated filter: users
[Info] 404 from filter, deleting custom
[Info] Filter download failed: custom
[Info] Updated all filters
DrKain commented 1 year ago

Thanks for reporting, I'll push a fix today

DrKain commented 1 year ago

Turns out the issue was already resolved but I skipped the build task, new release should work correctly. Thanks for reporting