DrMemCS / drmem

Full source tree for the DrMem control system
MIT License
3 stars 4 forks source link

Expanding character set for device names #20

Closed rneswold closed 1 year ago

rneswold commented 1 year ago

This pull request expands the characters we can use in device names. I added a couple of tests but they're not exhaustive. I wanted to test characters from cultures that don't use latin letters. So I used a Japanese example, which worked. I then tried using a Thai example but I couldn't get it to work. I'm not a Unicode expert so I don't know why Rust's char::is_alphanumeric function rejected some of the characters. If this project gets popular and some non-english speaking people find deficiencies, we can open another issue and do a more thorough job.

This resolves #12.