DrMoriarty / godot-facebook

Facebook module for Godot Game Engine (android and iOS)
MIT License
81 stars 22 forks source link

Will this also work for facebook ads manager? #15

Closed SoloCarryGuy closed 3 years ago

SoloCarryGuy commented 3 years ago

I wanted to know will this work for event logging with Facebook ads manager. Screenshot (269)

DrMoriarty commented 3 years ago

@SoloCarryGuy This plugin don't add dependency to facebook-marketing, but you can add it manually. For example see how https://github.com/DrMoriarty/godot-firebase-crashlytics adds dependency to the crashlytics library.

SoloCarryGuy commented 3 years ago

@DrMoriarty I am just a beginner with a few months of coding experience only in godot. I checked out the crashlytics link. And, I have tried to do it with some documentaion from facebook. this is done by you from what I understand. I have tried to implement this .This is the code I end up with gradle.conf looks like this:

[buildscript_repositories]

[buildscript_dependencies]

[allprojects_repositories]

[dependencies]
implementation 'com.facebook.android:facebook-android-sdk:5.+'
implementation 'com.facebook.android:facebook-marketing:[4,5)' 
implementation 'com.google.android.gms:play-services-ads:15.0.0'

[android_defaultconfig]

[global]

AndroidManifest.conf looks like this:

[user_permissions]
<uses-permission android:name="android.permission.INTERNET"/>

[application]
<activity android:name="com.facebook.FacebookActivity"
          android:configChanges="keyboard|keyboardHidden|screenLayout|screenSize|orientation"
          android:theme="@style/com_facebook_activity_theme" 
          android:label="@string/godot_project_name_string" />
<activity android:name="com.facebook.CustomTabActivity" android:exported="true"> 
          <intent-filter> 
                          <action android:name="android.intent.action.VIEW" /> 
                          <category android:name="android.intent.category.DEFAULT" /> 
                          <category android:name="android.intent.category.BROWSABLE" /> 
                          <data android:scheme="@string/fb_login_protocol_scheme" /> 
          </intent-filter> 
</activity>

<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/facebook_app_id" />
<meta-data android:name="com.facebook.sdk.CodelessDebugLogEnabled" android:value="true" />

[application_attribs]

Is this okay?

DrMoriarty commented 3 years ago

@SoloCarryGuy I think that you don't need AndroidManifest.conf at all. Only gradle.conf with dependencies.

SoloCarryGuy commented 3 years ago

So, what should I do to correct it? implementation 'com.facebook.android:facebook-marketing:[4,5)' This is the only dependency here

DrMoriarty commented 3 years ago

yes

SoloCarryGuy commented 3 years ago

Okay. Thanks for the help.