startserver.sh contains CRLF line endings, preventing execution on some systems

FubyCutie commented 10 months ago

Type of Instance

Multiplayer

Installation Target

Your Own Computer or Laptop

Your Actions

When running the startserver.sh script on my computer, I got the error "/bin/bash^M" no such file or directory, the ^M being the carriage return character

Your Pack Version

1.6.3

Required Logs

As this issue is pre-launch when the other logs do not exist yet, I have included the commandline output instead

zsh: ./startserver.sh: bad interpreter: /bin/bash^M: no such file or directory

Final Checklist

[X] I have provided all the required logs.
[X] I searched this issue tracker and there is nothing similar already.
[X] I can reproduce this crash consistently by following the exact steps I described above.

DrParadox7 commented 10 months ago

Is both MR and CF affected?

FubyCutie commented 10 months ago

I installed from Modrinth, unsure for curseforge, it seems to be an error with the startserver.sh file itself, not how it is packaged, so if that file is on both it should be an issue on both

idk-some-guy commented 8 months ago

Was browsing issues, possibly duplicate or regression of #79

can confirm, same issue, same fix on 1.6.4. Modrinth hubrid download -> affected (startserver.sh in .minecraft directory as installed using Prism Launcher) Curseforge separate server download -> not affected and works as expected.

DrParadox7 / Lost-Era-Modpack