closing price violin and boxplot have non-sensical y-axis

DrPaulBrewer / single-market-robot-simulator-viz-plotly

middleware for generating charts with plotly from single-market-robot-simulator simulation logs

Other

1 stars 0 forks source link

closing price violin and boxplot have non-sensical y-axis #10

Closed DrPaulBrewer closed 4 years ago

DrPaulBrewer commented 4 years ago

In particular the y-axis is not strictly ascending.

Only affects study level plots.

The 2-d histograms with closing prices look ok.

DrPaulBrewer commented 4 years ago

Stepping through an example, I can see that sim is inaccessible in getLayout()

This prevents reading sim.config.H in axisRange() to set up the price axis.

The same issue occurs in trade price violing/boxplot but it does not cause the y-axis artifact.

In both cases the y-axes are defaulting to whatever plotly will set up.

DrPaulBrewer commented 4 years ago

The next clue is that the first y data array in the closing price violin chart is an array of 1000 blank strings "". Subsequent y arrays are entirely numeric.

Recommendations:

find a way to omit individual sims from study charts and do so as circumstances dictate (e.g. invalid data)
modify getLayout() to accept both sim and sims, with dependencies also suitably modified so that price ranges, etc., can be aggregated properly across multiple charts

DrPaulBrewer commented 4 years ago

fixed in 5.18.0 by 65ad352e5c1e4f7f7b6a75cc67ea683f04546f60

checked various data arrays using assertContiguousFiniteNumberArray()

no change to getLayout()