DrPlantabyte / ElectricAdvantage

Add the power of electricity to your Minecraft game with this Power Advantage add-on mod
GNU General Public License v3.0
5 stars 1 forks source link

Switches conflict with toggling of machines #13

Closed OhiraKyou closed 8 years ago

OhiraKyou commented 8 years ago

Examine this album of a before and after screenshot featuring a chain consisting of an unlimited electrical power block connected to a switch that, in theory, should control the three mining drills that follow. Notice that, in the second screenshot, in which the switch has been activated, the first drill is off while the others are on.

Currently, machines, such as the mining drill, are disabled by sending a redstone signal. However, switches are enabled with a signal. This inconsistency means that a compact chain of power source > switch > machine > machine fails due to the first machine being disabled by the same redstone signal that enabled the switch.

This can be solved by inverting the switch's state so that it, like machines, is on by default and off when a redstone signal is applied.

Also, I should mention that this likely applies to Steam Advantage as well. And, right-clicking as the documentation instructs does not toggle the switch.

DrPlantabyte commented 8 years ago

Oops, I forgot to edit the documentation (my bad). I had to remove the right-clicking feature because any block update in a neighboring block would trigger a redstone input check, which would then undo the right-click. All machines output a redstone signal (via a comparator) proportional to the number of input items they hold (or their power level for non-inventory machines), so placing a switch next to a machine will cause it to update frequently and making the right-click behavior completely useless in compact builds.

I suppose I could invert the input.

DrPlantabyte commented 8 years ago

Next version will have inverted input. Documentation has been updated.