DrPlantabyte / PowerAdvantageAPI

API for Minecraft Forge 1.8 mods that have power systems
GNU Lesser General Public License v3.0
8 stars 2 forks source link

Filtered Conveyor only fills half double-chest #13

Closed 7eggert closed 8 years ago

7eggert commented 8 years ago

When I put a double chest directly under a filtering Conveyor (Smeltables, Ores), it will only filter into the half chest directly under the conveyor. The normal (non-matched) output correctly fills the output container.

My mods: BaseMetals_1.9-2.2.2.jar Chunk-Edge-Indicator-Mod-1.9.jar CyanosLootableBodies_1.9-2.0.0.jar ElectricAdvantage_1.9-2.0.3.jar Excore-1.9.jar Forever-Enough-Items-Mod-1.9.jar Just-Enough-Items-Mod-1.9.jar LLOverlayReloaded-1.0.7-mc1.9.jar Mineralogy_1.9.0-3.0.1.jar OptiFine_1.9.0_HD_U_B1.jar PowerAdvantage_1.9.0-2.1.0.jar ProgressiveAutomation-1.9-1.6.42.jar SteamAdvantage_1.9-2.0.3.jar bdlib-1.11.0.14-mc1.9.jar fluxducts-mc1.9-1.0.3.jar hopperducts-mc1.9-1.4.7.jar pressure-1.3.1.13-mc1.9.jar

BitForger commented 8 years ago

I don't think there is a fix for that. Possibly a very complicated workaround but that is just something I came up with in my head. No proof of concept. The large chest is one tile entity but two seperate blocks. That's probably not the right explanation... Basically it's two blocks that when placed next to each other change the texture to one block and display a double sized inventory GUI when right clicked. If your feeding items into the right side of the chest it's going to fill up starting at the highest slot value for that inventory block.

7eggert commented 8 years ago

I know that double chests need special handling, but the same problem happened to the vanilla hoppers, too, now they fill double chests. That was obviously fixed by having special handling in each output.

I guess also the conveyor originally used targetblock.putItem(), then the non-filtered output was changed to chestput(targetblock), but that change wasn't applied to derived conveyors. (Names made up on the spot).

DrPlantabyte commented 8 years ago

Actually, the conveyors ask the bock for its inventory handler and then uses that directly. Double-chests used to have a single handler for both blocks. I don't know when that changed, but I'll see what I can do.

EDIT: Conveyors seem to be working properly. Maybe it was a Forge bug? Try updating to Forge 1.9-12.16.1.1894

7eggert commented 8 years ago

Nope. I loaded the current forge …1898 and the latest power advantage 2.1.1, no change. Only the normal in/out accept chests.

I uploaded my world and my mods to http://7eggert.selfhost.bz/tmp/pa13/

(Also it's cheaper to use a large chest instead of a pure row of conveyors (should be documented?), and in a row of conveyors, normal conveyors seem to pull supposed-to-be-filtered-out items out of blocked conveyors. Possibly to-be-expected, but filtering conveyors don't do that. If this is not an intended behavior, I could open another issue.)

DrPlantabyte commented 8 years ago

Could you post a screenshot showing what you mean?

7eggert commented 8 years ago

2016-06-04_05 11 21


I tested the normal conveyor after that filtering conveyor, too, it didn't pull out filtered items. That was due to having another filtering conveyor below, a different bug.

DrPlantabyte commented 8 years ago

Thanks. I'll work on it.

DrPlantabyte commented 8 years ago

Found the bug. Will be fixed in the next release.