search

DrSuperGood / SC2-UA3

Undead Assault 3 map for StarCraft II
GNU General Public License v2.0
13 stars 10 forks source link

Farmer Akma Mission Still Broken #12

Closed ChildServices closed 7 years ago

ChildServices commented 7 years ago

Title speaks for itself, however I've noticed that it doesn't happen as often, if at all, with higher player counts (above 7-8 or so)

willmon8 commented 7 years ago

This was listed in previously closed "Issue #8", but UA3 players were reporting having no such problem and I wasn't able to duplicate it in public games. It didn't occur to me to re-try the 4 man games where I first experienced the bug. Unsure why this would be effected by number of players. Perhaps REDCELL5 can figure it out.

willmon8 commented 7 years ago

Tested tonight three times in solo gameplay. First time, nothing happened after BMDDs failed - game stagnated indefinitely. Second time, Chapter 1 started and Akma mission request was displayed after BMDDs failed. Third time, worked again as it should after BMDD failure. Unsure what triggers this.

UAAnubis commented 7 years ago

Please take a look at PR #16 and let me know what you think.

UAAnubis commented 7 years ago

There also seems to be an off-by-one error in completion checks for Akma Loop, which causes the mission to be completed with one less silo than intended.

DrSuperGood commented 7 years ago

Please take a look at PR #16 and let me know what you think.

That solution looks iffy...

There also seems to be an off-by-one error in completion checks for Akma Loop, which causes the mission to be completed with one less silo than intended.

The end conditional test seemed to have been designed for an index 0 start and not index 1 start.

I could swear that mission worked perfectly when I stopped development. I am guessing one of the previous pull requests must have broken it, sigh...

I will be publishing a fixed version to Blizzard servers shortly. Please test and let me know if it is really fixed so this can be closed.

DrSuperGood commented 7 years ago

So is this solved or is it not? It is hard to manage a project if people do not provide feedback...

UAAnubis commented 7 years ago

Apologies. I did not have the chance to test until yesterday. It seems to be working correctly now.

Thanks for your efforts.