DrTimothyAldenDavis / GraphBLAS

SuiteSparse:GraphBLAS: graph algorithms in the language of linear algebra. For production: (default) STABLE branch. Code development: ask me for the right branch before submitting a PR. video intro: https://youtu.be/Tj5y6d7FegI .
http://faculty.cse.tamu.edu/davis/GraphBLAS.html
Other
360 stars 63 forks source link

GRB_VERSION / GrB_SUBVERSION #17

Closed eriknw closed 4 years ago

eriknw commented 4 years ago

On page 45 of "GraphBLAS_API_C_v13.pdf", I see:

#define GRB_VERSION     1
#define GrB_SUBVERSION  3

I am surprised by the use of GRB (all caps), and also the inconsistency (GRB and GrB). Do you know whether these should both be GRB (as you define them in your header file), or GrB? I know this is more of a GraphBLAS question, but I wasn't sure where else to ask.

DrTimothyAldenDavis commented 4 years ago

That's a typo in the v1.3 C API. It's fixed in the latest version of the C API, and SuiteSparse:GraphBLAS uses the corrected version: GRB_VERSION and GRB_SUBVERSION.

Yes, I would prefer the GrB_VERSION and GrB_SUBVERSION, but the C API committee went with GRB, not GrB. This is the only instance of the GRB (all caps) prefix in the API. I think the reasoning is that this is the only place where the library must define a C macro, with a #define. All other constants are enums and such. So they used all caps for the names of the 2 macros.

On Mon, Aug 31, 2020 at 4:59 PM Erik Welch notifications@github.com wrote:

On page 45 of "GraphBLAS_API_C_v13.pdf", I see:

define GRB_VERSION 1

define GrB_SUBVERSION 3

I am surprised by the use of GRB (all caps), and also the inconsistency ( GRB and GrB). Do you know whether these should both be GRB (as you define them in your header file), or GrB? I know this is more of a GraphBLAS question, but I wasn't sure where else to ask.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DrTimothyAldenDavis/GraphBLAS/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYIIOMESOIKAFPZQA2MRJTSDQMNJANCNFSM4QQ7MS2A .

eriknw commented 4 years ago

Okay, thanks for the explanation!