search

DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.15k stars 259 forks source link

Error in CSparse Makefile #29

Closed sekocabas closed 2 years ago

sekocabas commented 4 years ago

I had compilation errors for CSparse when using icc. I had to add the following lines to the top of the Makefile to get it to work.

SUITESPARSE ?= $(realpath $(CURDIR)/..)
export SUITESPARSE
include ../SuiteSparse_config/SuiteSparse_config.mk
DrTimothyAldenDavis commented 4 years ago

this isn't a bug, it's a feature. CSparse is a stand-alone package and cannot depend on any other code, including SuiteSparse_config. It's meant for educational use. Production use should depend on CXSparse, which is a version of CSparse that adds complex types, and also depends on SuiteSparse_config. CSparse is compiled by the top-level Makefile, but not installed in the "make install".

Instead of adding a SuiteSparse_config dependency, I could see about removing the line "cd CSparse && make) from the top-level Makefile

sekocabas commented 4 years ago

Thank you for the explanation. I am a very novice user of SuiteSparse, and was actually compiling SuiteSparse for use in another code base which needed CHOLMOD. Your suggestion sounds very reasonable to me.