search

DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.15k stars 259 forks source link

Example: Remove explicit import of transient dependencies. #659

Closed mmuetzel closed 8 months ago

mmuetzel commented 8 months ago

That should no longer be needed. And removing them should allow the CI to check if the CMake Config files are complete.

DrTimothyAldenDavis commented 8 months ago

Looks great -- thanks.

DrTimothyAldenDavis commented 8 months ago

I'm seeing errors when building the Example when not using the top level CMakeLists.txt. After "make local ; make install ; cd Example ; make" I get:

CMake Error at /home/davis/dev2/SuiteSparse/lib/cmake/ParU/ParUTargets.cmake:62 (set_target_properties):
  The link interface of target "SuiteSparse::ParU_static" contains:

    OpenMP::OpenMP_CXX

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /home/davis/dev2/SuiteSparse/lib/cmake/ParU/ParUConfig.cmake:121 (include)
  CMakeLists.txt:104 (find_package)
mmuetzel commented 8 months ago

Looking into it.

mmuetzel commented 8 months ago

PR #662 should fix this issue.