search

DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.15k stars 259 forks source link

CHOLMOD: Don't use macOS extensions of math library #690

Closed mmuetzel closed 8 months ago

mmuetzel commented 8 months ago

Limit scope of workaround to affected libraries only.

Also use the correct name of the preprocessor definition __NOEXTENSIONS__. (See: https://opensource.apple.com/source/Libm/Libm-92/i386.subproj/math.h.auto.html)

Should be fixing #682.

DrTimothyAldenDavis commented 8 months ago

Yes, that would be better. But it also needs to be added to KLU/CMakeLists.txt too.

mmuetzel commented 8 months ago

But it also needs to be added to KLU/CMakeLists.txt too.

Oops. It's probably only needed in KLU... https://github.com/macports/macports-ports/commit/e485b0a0c8125cb9d8bcc6241a9c2016514188c8#diff-93ed37ccf33fb803f40494f870c28d04b1b3cb795de482ce3c536a49c75f39b1

mmuetzel commented 8 months ago

Grepping for Real and looking at where those files are included, the broader approach might have been the better one. Apart from KLU and CHOLMOD, it's also umf_version.h from UMFPACK (and hence by extension also ParU) and Tcov in SPQR (and maybe others?) that need that change...