DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.15k stars 259 forks source link

Disable extensions in math.h with older versions of macOS for all projects #693

Closed mmuetzel closed 8 months ago

mmuetzel commented 8 months ago

Afaict, more libraries apart from KLU and CHOLMOD might need this workaround on older versions of macOS.

This essentially reverts to your original change (with the typo fixed).

Sorry for the confusion.

DrTimothyAldenDavis commented 8 months ago

Sure thing. This is probably a good idea since I don't think any of the packages in SuiteSparse need these extensions.

Revising the fix for https://github.com/DrTimothyAldenDavis/SuiteSparse/issues/682

DrTimothyAldenDavis commented 8 months ago

And in the future, when I revised UMFPACK to handle single precision matrices like CHOLMOD, I might use the same thing, as

#define Real float or

#define Real double