DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.15k stars 259 forks source link

SPQR: Slightly overhaul code of GPU libraries #704

Closed mmuetzel closed 8 months ago

mmuetzel commented 8 months ago

This mostly avoids warnings with some compilers. If I understand those warnings correctly, they point to valid "issues":

DrTimothyAldenDavis commented 8 months ago

It's been a while since I touched this code, and also a long time since I've worked with the C++ placement new technique. It will take me some time to get back up to speed and try it out.

DrTimothyAldenDavis commented 8 months ago

I'd like to converge to a stable SuiteSparse 7.5.0 release soon. I'll try to include these changes.

DrTimothyAldenDavis commented 8 months ago

My GPU tests are passing so I'll merge this in.