search

DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.14k stars 258 forks source link

GraphBLAS: Disable JIT compiler by default when cross-compiling. #730

Closed mmuetzel closed 7 months ago

mmuetzel commented 7 months ago

I was hoping that users that cross-compile libraries to a different target understand their toolchains. But that doesn't seem to be the case generally. To improve the out-of-the-box experience for those users, disable the JIT compiler by default when cross-compiling. Interested users could still enable it (and supply settings for a working native toolchain).

DrTimothyAldenDavis commented 7 months ago

The JIT is extremely important for performance. Cross-compiling is something not done by a typical user, but by someone who should know how to use toolchains on both the host and the target. I'd rather have them try to get the JIT to work, and in the worst case, if they can't get it to work then they can select a non-default option to turn off the JIT.

mmuetzel commented 7 months ago

That sounds reasonable. We probably just have to live with users that come with unreasonable expectations.