Closed mmuetzel closed 8 months ago
Yes, CXSparse doesn't support MSVC's half-baked complex type. I have tagged it as a possible future extension:
Regarding overlinking: I'd like to revise CXSparse/Source/cs_malloc so that it calls SuiteSparse_config_malloc and friends, which themselves call malloc by default. I just haven't gotten around to it yet. So I'd prefer to keep the overlinking for now, or at most just comment it out so I can easily add it back in.
Regarding overlinking: I'd like to revise CXSparse/Source/cs_malloc so that it calls SuiteSparse_config_malloc and friends, which themselves call malloc by default. I just haven't gotten around to it yet. So I'd prefer to keep the overlinking for now, or at most just comment it out so I can easily add it back in.
Oops. I now remember that you wrote the exact thing a couple of weeks ago. Sorry, I forgot.
Stripped that part of the PR.
I think this is a good reminder for me to revise CXSparse to use the SuiteSparse_config_malloc functions and friends anyway. I'll do that shortly.
For
clang
/clang++
targeting MSVC, the CMake variableMSVC
is not set (only forclang-cl
targeting MSVC). However, the MSVC target uses different types for complex numbers that CXSparse doesn't support (yet?).Deactivate complex number arithmetic for CXSparse also for any compiler that targets MSVC.
Also, avoid overlinking the CXSparse library with libsuitesparseconfig. (It only uses the header but no functions from it.)