search

DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.
https://people.engr.tamu.edu/davis/suitesparse.html
Other
1.15k stars 259 forks source link

CI (alpine): Add an emulated RISC-V 64-bit runner #810

Closed mmuetzel closed 4 months ago

mmuetzel commented 4 months ago

This is a simpler alternative to #801 now that Alpine Linux 3.20 is released that includes packages for RISC-V 64.

Like @suvorovrain already wrote in that PR, valgrind isn't packaged for that architecture. (Upstream valgrind doesn't support that architecture.) I'm not sure why it is installed in the first place on those runners. Could it be removed entirely?

DrTimothyAldenDavis commented 4 months ago

valgrind could be removed, or better yet it could be commented out. I had it there in case I need to debug something through the github CI, where an error was occuring on some platform I didn't have access to except through the github runners. Some of the demos and examples can be run with valgrind, by editting the Makefiles.

mmuetzel commented 4 months ago

Thank you for clarifying. I added a commit that comments out the line that would install valgrind. (I hope I didn't mess up the YAML syntax by that change.)

DrTimothyAldenDavis commented 4 months ago

Looks good. Shall I merge it in now or would it best to wait for all the CI's to finish?

mmuetzel commented 4 months ago

Looks good. Shall I merge it in now or would it best to wait for all the CI's to finish?

I believe that file is still valid YAML with the last change. But it would probably be best to wait at least until (and if) the CI starts with that change.

mmuetzel commented 4 months ago

It looks like the new runner built and checked without issues. 🎉

(Only slightly related: Still no feedback on the bug report regarding the lapack packages on the aarch64 and ppc64le Alpine Linux runners.)