SPEX: Account for SUITESPARSE_USE_STRICT when using SPEX_USE_PYTHON

DrTimothyAldenDavis / SuiteSparse

The official SuiteSparse library: a suite of sparse matrix algorithms authored or co-authored by Tim Davis, Texas A&M University.

https://people.engr.tamu.edu/davis/suitesparse.html

Other

1.11k stars 256 forks source link

SPEX: Account for SUITESPARSE_USE_STRICT when using SPEX_USE_PYTHON #817

Closed mmuetzel closed 1 month ago

mmuetzel commented 1 month ago

Handle SPEX_USE_PYTHON similar to SPEX_USE_OPENMP when SUITESPARSE_USE_STRICT is ON.

Another addendum to #805.

mmuetzel commented 1 month ago

The latest commit uses a default value of OFF for SPEX_USE_PYTHON if BUILD_SHARED_LIBS evaluates to false. I'm wondering if it would be better to make the default value of SUITESPARSE_USE_PYTHON dependent on BUILD_SHARED_LIBS instead...

What do you think?

mmuetzel commented 1 month ago

Re-opening to trigger the CI again. The issue with the package signatures from Alpine Linux should be fixed now: https://gitlab.alpinelinux.org/alpine/aports/-/issues/16136

DrTimothyAldenDavis commented 1 month ago

Looks great -- thanks!