DrWala / pe

0 stars 0 forks source link

UG does not specify that assigning tutors cannot have a timeslot clash #6

Open DrWala opened 3 years ago

DrWala commented 3 years ago

What the UG say

The docs do not specify that tutors cannot be assigned to a conflicting session.

This is only made known when trying to attempt it image.png

Why is this an issue

Users should be told about the limitations of the assign command on the UG

nus-pe-bot commented 3 years ago

Team's Response

While not specified, it is an implicit requirement for any tuition center. This is also stated in edit. The error is also present to catch this case.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Following your response to look at edit (I assume the edit_session since the responder did not specify). The edit section does not talk about the limitations of the assign command which was claimed by the responder.

Therefore, the team should add this missing limitation of the assign command in the UG.

As an aside, one should not go to the edit command of a function to see its limitations. If the limitation kicks in during the assign command, then it should be documented in the assign command section.

I have attached the section for easy viewing.

image.png