DrZhivago1 / DocWorld

A mod of combined patches for RimWorld and RimWorld mods.
GNU General Public License v3.0
10 stars 14 forks source link

More usable props. #76

Closed Keno-GH closed 3 years ago

Keno-GH commented 3 years ago

Took me a bit longer than I thought. Here is a summary of the changes I did:

Vanilla storage

Dubs Bad Hygiene

Fertile fields

Rimatomics

Rimfridge

DrZhivago1 commented 3 years ago

Cool, I give it a look over and we'll get it included for the next update.

Edit: Also note that I'm removing support for specified storage within items as it makes mod compat more difficult. Every item will be able to store anything, but limited to storage size restrictions.

Keno-GH commented 3 years ago

I am a bit sad to hear that you are removing specified storage, but it's totally understandable.

DrZhivago1 commented 3 years ago

You did pretty good. Missed one dependency in the patch for RimFridge, and I removed some excess fields that we'll no longer need b/c I also changed the inheritance for all items. As I said, I've also removed specified storage. Yes it allows for unrealistic possibility. However given the greater benefit of mod compatibility, and the options in-game for players to restrict/allow whatever they want with settings, it's a good trade-off.

That being said, the way you've setup this PR is difficult. You moved a lot of files and that causes me to not be able to smoothly transition the file for a merge. Also your file was not pulled from the latest master, so the changes that should be there were not, which again just takes more time to review. Finally I'm not allowed to edit anything, which is fair. However it doesn't let me merge either because I can't update it to my standard. Idk GitHub very well.

So I'm going to drop the new file here and if you overwrite your branch with it I will pull it into Master. That's just to keep track of your credit. VFE_Usable_Props.zip

DrZhivago1 commented 3 years ago

Idk how to resolve this shit so fuck it lol

Keno-GH commented 3 years ago

Just copy and paste the new code. I started working with an earlier version of VFE_Usable_props.xml because it got updated while I was working on it. But I documented every change.

Edit: I don't mind credit at all. I just don't want to create more duplicated "functional props" mods in the workshop, so don't worry about it.

DrZhivago1 commented 3 years ago

Yea I've got the changes encorporated. I just accidentally overwrote some new stuff I was working on that I hadn't pushed yet so I'm trying to do some recovery.

Keno-GH commented 3 years ago

I am making a mod on my own to rebalance most storage mods out there, including this one + VFEP. I am telling you this now because I thought it would be good to know. I am taking into consideration your on-going changes on this master, as well.

The rebalance will include fixed filters, max stacks, required research, costlists and stacking time cost.