Drachenfrucht1 / godotcord

A Discord Game SDK integration for Godot
https://drachenfrucht1.github.io/godotcord
MIT License
53 stars 5 forks source link

Fix typo in network peer and "local_user_updated" signal #69

Closed Peatral closed 3 years ago

Peatral commented 3 years ago

peer is not spelled "perr" ;P

(btw, I realized a year ago that I would have to implement a multiplayer peer on my own and because I have no real clue how c++ works I am happy that someone else did it 👍)

Peatral commented 3 years ago

If you want to get the user right after initializing discord, you will get an empty dictionary, because the user gets updated short after. Adding this signal helps you to get the user data as soon as it is ready.

sairam4123 commented 3 years ago

I think, instead of getting the user from the manager every time the local_user_updated is emitted, I'd better pass the user in the function, I don't know if this workflow be better.