Any plans to forward-port some of the Ore Flowers config from 1.7.10...?

[cosmicdan]

Howdy,

Just wondering if you have plans to forward-port any of the config changes I made on the old Ore Flowers versions?

Specifcally: https://github.com/Draco18s/HarderStuff/commit/0349d4fc7b67d18d2c89874fc9cbb9775341bfa3 https://github.com/Draco18s/HarderStuff/commit/9d85734fe1869c08cb752e8f014b06844a3fd750 https://github.com/Draco18s/HarderStuff/commit/ee6e76ec999e0f8a5af6767c694d4a568edf3a3f

The others are not as important IMO.

Also, I can't tell since of major refactoring - did you also adjust the flower patch placement to be on the chunk center rather than the origin (as I did in https://github.com/Draco18s/HarderStuff/commit/53f60316117aabea653f1f12fc8fc8f83d766e71 )?

Cheers

EDIT: Oh. I'll be happy to make a PR, if you don't mind.

[Draco18s]

53f6031 is a thing I should do. Thanks for pointing that one out. Edit: Actually, the new code doesn't need it. It uses block-pos-origin already: each block scanned acts as the point of origin on the cluster.

The config stuff I'll have to look at. The 1.10+ code is set up differently, using a set of common dictator objects, as there are two different types of flowers: grass-growing and sand-growing and both flower types need to have the same distance and spawn chance so that when a cluster is created, both types of flowers show up there.

(Bonemeal depth should be the same though, Edit: done).

[cosmicdan]

Fair enough, good to see that you've been busy!

Those options might not be so much of a need for us now that we're using COG and much larger veins than we originally were with CoFH oregen, but I think it'd still be nice to have a configurable fuzz :)

On 22 Sep 2017, Draco18s notifications@github.com wrote:

53f6031 is a thing I should do. Thanks for pointing that one out.

The config stuff I'll have to look at. The 1.10+ code is set up differently, using a set of common dictator objects, as there are two different types of flowers: grass-growing and sand-growing and both flower types need to have the same distance and spawn chance so that when a cluster is created, both types of flowers show up there.

(Bonemeal depth should be the same though).

-- Sent with K-@ Mail - the evolution of emailing.

[Draco18s]

Yeah, COG veins are way different than CoFH. I'll see what I can do about configifying the Dictators.

The number of flowers and the cluster size are moderately constant (just gives the different patches a more or less packed feeling; tends to be inversely proportional), and the threshold is pretty ore-specific (to avoid causing massive flower patches from spawning due to motherloads, which can easily have 400 blocks in a very small area). So I don't feel a need to configify those.

[cosmicdan]

Oh, sounds cool!

One other thing, a few mods (including yours) are throwing “cascading worldgen lag” warnings to the log. Apparently you need to not notify of neighbour changes when using setBlock when decorating a chunk or something like that. Or it might be a Forge problem, not sure... See http://www.minecraftforge.net/forum/topic/60801-112-cascading-worldgen-lag/

Regards, Daniel Connolly

From: Draco18s Sent: Saturday, 23 September 2017 2:23 To: Draco18s/ReasonableRealism Cc: Daniel Connolly; Author Subject: Re: [Draco18s/ReasonableRealism] Any plans to forward-port some ofthe Ore Flowers config from 1.7.10...? (#14)

Yeah, COG veins are way different than CoFH. I'll see what I can do about configifying the Dictators. The number of flowers and the cluster size are moderately constant (just gives the different patches a more or less packed feeling; tends to be inversely proportional), and the threshold is pretty ore-specific (to avoid causing massive flower patches from spawning due to motherloads, which can easily have 400 blocks in a very small area). So I don't feel a need to configify those. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Draco18s]

Actually it is from COG. I don't know how to fix it. I mean, I've read that reddit post, but I don't know how to fix COG.

[Draco18s]

Catching up on things: Is there something here that has not been addressed and should be considered?

[cosmicdan]

Hmm can't remember....

@Dulciphi is anything missing? We did decide to keep Ore Flowers, right?

[Draco18s]

Closing this for now, there's been no activity for a while.