search

Draco18s / ReasonableRealism

For 1.10!
Other
17 stars 8 forks source link

[1.12.2] HarderFarming nullpointerexceptions #23

Closed Matryoshika closed 5 years ago

Matryoshika commented 6 years ago

Minecraft: 1.12.2 Harder Farming: 4.0.0d Forge: 14.23.4.2739 OpenTerrainGenerator: v6

First I got a nullpointer for ticking world. I then relaunched the pack without any coremods (well, bar OTG's) to make sure that they are not causing any mischief, which has led me to a second nullpointer while updating neighbours.

I am seeing this happen in worlds with OpenTerrainGenerator, using custom biomes, a feature of said mod. This is happening no matter which value B:EnableCropSlowingByBiome is set to.

Draco18s commented 6 years ago

Interesting. Thanks for the report. The crash is helpful (narrows down the possible cause to a single method but the line number is useless. :\

(Both crashes are the same, which is good)

I suspect something is going on with the biome there on 487 or 488, but I'm not sure why.

Draco18s commented 6 years ago

I'm forwarding this issue to OTG. https://github.com/PG85/OpenTerrainGenerator/issues/196

Draco18s commented 6 years ago

Realized the line number isn't useless as I was looking at the wrong branch. And the newly opened issue #27 gave me line 645. Which at least is in the right method...my dev copy is likely out of date and shifted something around.

And I think I figured out the problem.

LemADEC commented 6 years ago

Issue is reproduced without OTG.

LemADEC commented 6 years ago

This NPE is lagging our server. Any chance you push your latest changes so we can look into it? In our case, it happens in Thaumcraft's Magical Forest. From a quick check in the code, the mod is caching biome temperatures. I suspect this is done too soon (i.e. before other mods have registered their biomes).

I'm a bit confused on why there's Map from Biomes to temperature since we can directly call getTemperature() on the biome. Is it to adjust those values from their default?

Draco18s commented 6 years ago

New version of the jar already went up with the issue fixed.

I'm a bit confused on why there's Map from Biomes to temperature since we can directly call getTemperature() on the biome. Is it to adjust those values from their default?

Yes, it is/was to handle seasonal shifts, even if there are no current seasonal shifts. I wanted to rely on a separate mod (e.g. Stellar Sky) to handle year-time and just never got around to getting things worked out.

LemADEC commented 6 years ago

6.0.0a is reproducing the issue, so I guess the patch is partial?

Draco18s commented 6 years ago

I'll take another look, thanks. (And push the code to git when I get a chance)

Draco18s commented 6 years ago

Recheck Oh, the thing I thought I did that would (should?) have fixed it got lost. Pushing a new version of H.F. soon.