search

Draco18s / ReasonableRealism

For 1.10!
Other
17 stars 8 forks source link

Can't milk cows when aging is set to 0 (1.12) #49

Open Xonok opened 2 years ago

Xonok commented 2 years ago

I've disabled aging because I don't want animals to die. With the current logic that means cows never become milkable. What would I need to change to add a separate config option that works like aging, but for milk?

Draco18s commented 2 years ago

Technically the intent was that aging just disables the need for grass, but it looks like there's a different issue that only crops up if global aging is off:

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/farming/entities/ai/EntityAIMilking.java#L51

wasGrassNearRecently is never assigned to, so it has a default value of false.

Just change that line to be hasGrass = true (and if you wanted to clean up, just delete the private field wasGrassNearRecently and the unused method that returns it).

Xonok commented 2 years ago

Okay, I tried to compile the 1.12 version today for a while. Got through a lot of errors relating to stuff missing and mismatched versions, but I don't know what to do about this one:

D:\Programming\Private\ReasonableRealism>gradlew build
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.9/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing

> Configure project :
This mapping 'snapshot_20170624' was designed for MC 1.12! Use at your own peril.
WARNING: You are using an unsupported version of ForgeGradle.
Please consider upgrading to ForgeGradle 5 and helping in the efforts to get old versions working on the modern toolchain.
See https://gist.github.com/TheCurle/fe7ad3ede188cbdd15c235cc75d52d4a for more info on contributing.
#################################################
         ForgeGradle 2.3.4-gfc67182
  https://github.com/MinecraftForge/ForgeGradle
#################################################
                 Powered by MCP
             http://modcoderpack.com
     by: Searge, ProfMobius, R4wk, ZeuX
     Fesh0r, IngisKahn, bspkrs, LexManos
#################################################
Version string '' does not match SemVer specification
You should try SemVer : http://semver.org/

> Task :compileJava FAILED
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:1: error: class, interface, or enum expected
module ReasonableRealism {
^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:3: error: class, interface, or enum expected
        exports com.draco18s.farming.integration;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:4: error: class, interface, or enum expected
        exports com.draco18s.ores.recipes;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:5: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.recipes;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:6: error: class, interface, or enum expected
        exports com.draco18s.flowers;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:7: error: class, interface, or enum expected
        exports com.draco18s.industry.network;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:8: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.interfaces;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:9: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.internal.inventory;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:10: error: class, interface, or enum expected
        exports com.draco18s.farming;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:11: error: class, interface, or enum expected
        exports com.draco18s.farming.block;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:12: error: class, interface, or enum expected
        exports com.draco18s.flowers.item;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:13: error: class, interface, or enum expected
        exports com.draco18s.ores.client.rendering;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:14: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.blockproperties.ores;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:15: error: class, interface, or enum expected
        exports com.draco18s.hardlib.client;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:16: error: class, interface, or enum expected
        exports com.draco18s.industry.client;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:17: error: class, interface, or enum expected
        exports com.draco18s.hardlib;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:18: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.blockproperties.flowers;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:19: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.advancement;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:20: error: class, interface, or enum expected
        exports com.draco18s.industry.block;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:21: error: class, interface, or enum expected
        exports com.draco18s.industry.client.gui;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:22: error: class, interface, or enum expected
        exports com.draco18s.industry.item;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:23: error: class, interface, or enum expected
        exports com.draco18s.ores.block;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:24: error: class, interface, or enum expected
        exports com.draco18s.ores.integration;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:25: error: class, interface, or enum expected
        exports com.draco18s.industry.world;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:26: error: class, interface, or enum expected
        exports com.draco18s.flowers.states;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:27: error: class, interface, or enum expected
        exports com.draco18s.farming.util;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:28: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:29: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.internal;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:30: error: class, interface, or enum expected
        exports com.draco18s.industry.entities.capabilities;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:31: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.capability;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:32: error: class, interface, or enum expected
        exports com.draco18s.ores;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:33: error: class, interface, or enum expected
        exports com.draco18s.ores.client.gui;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:34: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.blockproperties;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:35: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.blockproperties.farming;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:36: error: class, interface, or enum expected
        exports com.draco18s.industry.entities;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:37: error: class, interface, or enum expected
        exports com.draco18s.farming.entities.capabilities;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:38: error: class, interface, or enum expected
        exports com.draco18s.industry.inventory;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:39: error: class, interface, or enum expected
        exports com.draco18s.ores.enchantments;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:40: error: class, interface, or enum expected
        exports com.draco18s.farming.entities;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:41: error: class, interface, or enum expected
        exports com.draco18s.hardlib.math;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:42: error: class, interface, or enum expected
        exports com.draco18s.ores.client;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:43: error: class, interface, or enum expected
        exports com.draco18s.farming.loot;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:44: error: class, interface, or enum expected
        exports com.draco18s.farming.entities.ai;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:45: error: class, interface, or enum expected
        exports com.draco18s.ores.entities.capabilities;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:46: error: class, interface, or enum expected
        exports com.draco18s.ores.item;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:47: error: class, interface, or enum expected
        exports com.draco18s.hardlib.api.date;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:48: error: class, interface, or enum expected
        exports com.draco18s.industry;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:49: error: class, interface, or enum expected
        exports com.draco18s.farming.world;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:50: error: class, interface, or enum expected
        exports com.draco18s.ores.inventory;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:51: error: class, interface, or enum expected
        exports com.draco18s.ores.entities;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:52: error: class, interface, or enum expected
        exports com.draco18s.flowers.block;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:53: error: class, interface, or enum expected
        exports com.draco18s.ores.networking;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:54: error: class, interface, or enum expected
        exports com.draco18s.ores.block.ore;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:55: error: class, interface, or enum expected
        exports com.draco18s.farming.client;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:56: error: class, interface, or enum expected
        exports com.draco18s.farming.item;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:57: error: class, interface, or enum expected
        exports com.draco18s.hardlib.util;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:59: error: class, interface, or enum expected
        requires java.desktop;
        ^
D:\Programming\Private\ReasonableRealism\build\sources\main\java\module-info.java:60: error: class, interface, or enum expected
}
^
58 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 13s
7 actionable tasks: 6 executed, 1 up-to-date
Draco18s commented 2 years ago

Wow.

o.O

I have no clue.

Try doing a clean (deleting the contents of the build folder) and try again.