search

DracoBlue / jsb

A very extendable Toolkit to inject Javascript Behaviour into rendered HTML without Inline Javascript. (jsb was formerly known as JsBehaviourToolkit)
http://dracoblue.net
Other
52 stars 8 forks source link

Modernize browser support and cleanup #29

Closed larslaade closed 8 years ago

larslaade commented 8 years ago

adding a UMD-wrapper to create a module (fixes #25) removing jQuery and MooTools functions removing attachEvent removing querySelectorAll fallback codestyle cleanup: whitespace, quotes, curly braces updated changelog and readme

DracoBlue commented 8 years ago

:+1:

Please update the changelog, too!

larslaade commented 8 years ago

@DracoBlue Should I add an UMD wrapper for issue #25 in this PR?

DracoBlue commented 8 years ago

UMD is a good idea!

Am Samstag, 9. April 2016 schrieb Lars Laade :

@DracoBlue https://github.com/DracoBlue Should I add an UMD wrapper https://github.com/umdjs/umd/blob/master/templates/returnExports.js for issue #25 https://github.com/DracoBlue/jsb/issues/25 in this PR?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/DracoBlue/jsb/pull/29#issuecomment-207853959

http://dracoblue.net

larslaade commented 8 years ago

Removed the commits for querySelectorAll and attachEvent. Updated changelog and readme.

DracoBlue commented 8 years ago

Looks good to me.