search

Draconic-Inc / BrandonsCore

Other
22 stars 26 forks source link

TeleportUtils.teleportPlayerInterdimentional conflicts with BetterPortals #69

Closed Johni0702 closed 3 years ago

Johni0702 commented 4 years ago

1.12.2 https://github.com/Johni0702/BetterPortals/issues/455 (only the DE part, the Mining World issue looks unrelated to me)

java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Third-party transfer but not all views have been disposed of!
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:192)
    at net.minecraft.util.Util.runTask(Util.java:531)
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:723)
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:668)
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:252)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalStateException: Third-party transfer but not all views have been disposed of!
    at de.johni0702.minecraft.view.impl.server.ServerWorldsManagerImpl.updateActiveViews(ServerWorldsManagerImpl.kt:70)
    at net.minecraft.server.management.PlayerChunkMap.handler$addPlayerWithViews$zei000(PlayerChunkMap.java:745)
    at net.minecraft.server.management.PlayerChunkMap.addPlayer(PlayerChunkMap.java)
    at net.minecraft.server.management.PlayerList.preparePlayer(PlayerList.java:290)
    at com.brandon3055.brandonscore.lib.TeleportUtils.teleportPlayerInterdimentional(TeleportUtils.java:169)
    at com.brandon3055.brandonscore.lib.TeleportUtils.handleEntityTeleport(TeleportUtils.java:87)
    at com.brandon3055.brandonscore.lib.TeleportUtils.teleportEntity(TeleportUtils.java:47)
    at com.brandon3055.brandonscore.utils.Teleporter$TeleportLocation.teleport(Teleporter.java:145)
    at com.brandon3055.draconicevolution.network.PacketDislocator$Handler.handleMessage(PacketDislocator.java:221)
    at com.brandon3055.draconicevolution.network.PacketDislocator$Handler.handleMessage(PacketDislocator.java:129)
    at com.brandon3055.brandonscore.network.MessageHandlerWrapper$1.run(MessageHandlerWrapper.java:19)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at net.minecraft.util.Util.runTask(Util.java:529)
    ... 5 more

For an explanation see https://github.com/DimensionalDevelopment/DimDoors/issues/130 it's basically the same issue except the offending method in DE is called teleportPlayerInterdimentional.