search

Draconic-Inc / BrandonsCore

Other
22 stars 26 forks source link

Update TeleportUtils.java #81

Closed FreezePhoenix closed 3 years ago

FreezePhoenix commented 3 years ago

Fixes and closes #69

brandon3055 commented 3 years ago

changeDimension uses the default vanilla teleporter for the dimension you are transferring to. If I'm not mistaken this means it will automatically generate portals when traveling between the overworld and the nether for example. Please correct me if I'm wrong.

FreezePhoenix commented 3 years ago

That is incorrect. Just tested, with an advanced dislocator between nether and overworld, and it didn't generate a nether portal.

I take that back, was running the wrong instance when testing this - please stand by.

FreezePhoenix commented 3 years ago

Latest commit removes generation of portals and obsidian platforms.

brandon3055 commented 3 years ago

So one of the primary reasons I created my fully custom teleport system was the vanilla teleporter system was a mess and horrible to implement in the way I wanted. But it's since been improved by a forge PR so it's not so bad these days. I looked into it and there are still a few things I don't like about it but I was able to come up with something I am happy with. You were on the right track but there were just a few issues with your PR (and my own code) that were easier to just fix myself.