Draconic-Inc / Draconic-Evolution

Other
337 stars 168 forks source link

Weird form of item duplication with Draconic Bow #1141

Closed Gutawer closed 5 years ago

Gutawer commented 6 years ago

Base information

Bug report

With the Draconic bow on the following settings:

Arrow of Draconic Fire: On
Shock Wave Power: 4.0
Arrow Base Damage: 3.0
Arrow Velocity Modifier: +100%
Auto Fire: On
Explosion Power: 0.0
Magnification 300

I managed to get an OpenBlocks grave to spawn with a previous version of my inventory by shooting an arrow at full pull-back straight into the air and standing near the landing spot. I got the on-screen message death.attack.customArrowEnergy, and upon entering my house noticed a grave which, when dug up, contained a previous version of my inventory. Unfortunately I could only get this to happen twice, else I would have recorded a video to show proof of this.

brandon3055 commented 6 years ago

what armor/enchantments are you using? Also its not clear from your message. Did you actually die? Or were you saved by DE armor or something like last stand?

Gutawer commented 6 years ago

I was using full Draconic Armour with no enchantments, and I did not die, the Draconic Armour appeared to stop me from dying while also causing me to "die", creating a grave inside my house (which is not where I was standing when this happened, weirdly enough). It seems like it killed some phantom version of my player from a while ago that the server was remembering, because an old form of my inventory was contained in the grave (the second time this happened, it had a slightly newer version of my inventory, I was in the process of upgrading from Wyvern to Draconic stuff). The server also has a Discord bot which reports chat logs which gave the message "Gutawer just died due to death.attack.customArrowEnergy!" in our Discord chat, except "I" never died.

brandon3055 commented 6 years ago

Hmm... That's a tough one... I have no idea where to even start debugging this. Mi first thought would have been the gravestone mod is not waiting to see if the death event was cancelled before spawning your grave but that wouldn't account for the older inventory.. That sounds like as you said the server is for some reason keeping an old version of your player entity in the world and when the death event fires its running on that invalid entity. If that is the case this may not be an issue with DE or the gravestone mod but with whatever is causing that "ghost player" to exist...

Gutawer commented 6 years ago

Only just checked my github notifications, sorry for taking so long to reply - I have noticed since reporting this that upon closing the server down, it'll say "Player Name has disconnected" for multiple players when they weren't online in the first place, so it appears as if the older players thing is what's causing this. My hunch would be that the inventories being dropped by these graves are the inventories of the players when they logged off, and that each "ghost" player is caused by leaving the server.

brandon3055 commented 6 years ago

Yea that's pretty much what i thought. Unfortunately i dont think there is much i can do from my end to fix this issue.

brandon3055 commented 5 years ago

I have made an adjustment on my end that may or may not fix this in the next release.