search

Draconic-Inc / Draconic-Evolution

Other
338 stars 169 forks source link

[Issue"s"] Draconic chest #1177

Closed BadLucKWyvern closed 5 years ago

BadLucKWyvern commented 6 years ago

Minecraft version:1.12.2 Mod version:Draconic-Evolution-1.12.2-2.3.13.306-universal Minecraft Forge version:1.12.2-forge1.12.2-14.23.4.2757

Im using draconics chest for temporary holding stuff ready to be transformed, like bees in liquid DNA I am putting bees manualy in the chest with the SHIFT+Click(or double click). When holding the Shift key, when the chest is around 2/3 full (usualy with shining item) Theres a terrible FPS drop,

The another issue, you're maybe not concerned. But Im using the inventory tweaks mod (wich allow items to be sorted in a single click) Clicking the default sort button with items in the chest only pack them, but not sorting them. The draconic chest is th lone chest wich i have that problem. Is it because the chest capacity size is too big ?

brandon3055 commented 6 years ago

I will take a look at it but I really dont think there is much i can do about the FPS issue as thats just a side effect of having so many render intensive items being drawn all at once. As for the inventory tweaks issue i need to dig into the IT api a bit to see if there is a way i can fix that. I think the issue is more likely related to the additional crafting/furnace slots in the ui. Inventory tweaks has no way of telling whats what.

brandon3055 commented 5 years ago

I have been looking into this and it does not look like there is much i can do. The lag im sure is just vanillas item rendering and inventory tweaks really has no way that i can find to add proper sorting support to a chest like this. I cant even move the buttons to a more convenient location.

BadLucKWyvern commented 5 years ago

You did what you could, that will not prevent me to play minecraft anyway, it just was a detail But about the lag issue, ghave you tryed with shining items? like forestry bees ?

Le mer. 31 oct. 2018 à 15:27, brandon3055 notifications@github.com a écrit :

I have been looking into this and it does not look like there is much i can do. The lag im sure is just vanillas item rendering and inventory tweaks really has no way that i can find to add proper sorting support to a chest like this. I cant even move the buttons to a more convenient location.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brandon3055/Draconic-Evolution/issues/1177#issuecomment-434707799, or mute the thread https://github.com/notifications/unsubscribe-auth/AQPSa-M6gsGtRcNfK-PGnbiV31EKv3pUks5uqbNcgaJpZM4W2Z-U .

brandon3055 commented 5 years ago

I dont think its specifically the glint effect on items. I tried completely filling a chest with enchanted books and that did drop my FPS more than say stone but not a lot more. You mention bees a lot. Have you reproduced this with any other items? I suspect however bees are rendered requires them to read data from the item every render frame and this could cause a lot more lag than the enchantment effect.

Edit: I just did some testing in a pack with bees but didn't really learn anything useful. The FPS is definitely a lot more unstable with bees or enchanted items but not enough to cause any noticeable lag though that may just be because i have a pretty powerful system which makes it hard to test issues that show up on mid-low end systems.