Draconic-Inc / Draconic-Evolution

Other
325 stars 165 forks source link

Fix mob soul blacklist, check blacklist before spawning #1650

Closed jeremiahwinsley closed 2 years ago

jeremiahwinsley commented 2 years ago
  1. Currently DEEventHandler.isValidEntity calls String.equals on an ITextComponent from entity.getName(), this always fails so the blacklist does not work. PR changes this to entity.getType().getRegistryName().toString().

This does have the side-effect of changing the blacklist to use registry IDs instead of whatever format entity.getName() returns, but since it didn't work before, this doesn't break anything.

  1. Also check isValidEntity on the powered spawner, so that mobs on the blacklist can't spawn even if the player got a soul for one previously.
brandon3055 commented 2 years ago

Looks good to me