search

Draconic-Inc / PI-Docs

The new home for the Project Intelligence documentation repository!
17 stars 19 forks source link

Add enderio translate(zh_cn) #6

Closed baka-gourd closed 5 years ago

baka-gourd commented 5 years ago

Add enderio translate.

baka-gourd commented 5 years ago

@brandon3055 :relaxed:

baka-gourd commented 5 years ago

@brandon3055

baka-gourd commented 5 years ago

@brandon3055

brandon3055 commented 5 years ago

Sorry for the delay. As this PR contains changes that effect mods that are not my own i would like @HenryLoenwind or someone else from the ender IO team to review them before i merge this PR.

HenryLoenwind commented 5 years ago

I don't read Chinese, so I can not really look at it properly. It only adds a Chinese translation, not changing the original, so I'd say it's fine.

baka-gourd commented 5 years ago

I don't read Chinese, so I can not really look at it properly. It only adds a Chinese translation, not changing the original, so I'd say it's fine.

Yes, I know that. I have checked it several times before submitting. I think it's not very good to insert small images in the document (like the icon of the ether wrench), which may affect reading. And perhaps should this be combined to update the mod translation?

brandon3055 commented 5 years ago

@HenryLoenwind I'm pretty much the same way with my localisations. But given the nature of PI i want to get the OK from the developer of a mod before i pull changes. This process will be a lot easier if @covers1624 ever gets around to finishing PiBot.

HenryLoenwind commented 5 years ago

sure and I appreciate it. I now turned notifications for this repo on so I'll notice it in the future without being pinged.