DraconisCluster / DX-Issues

Tracking for confirmed bugs
0 stars 0 forks source link

Pasting GPS in Alliance Chat Crashes Client #10

Closed subbob closed 3 months ago

subbob commented 4 months ago

tl; dr Pasting GPS point into Alliance chat immediate disconnects client

Full info Screenshot and Video Clip below.

Screenshots --If applicable, add screenshots to help explain your problem.-- image

https://github.com/DraconisCluster/DX-Issues/assets/5113030/6baddabc-e510-4c27-b5c3-5194be27299d

subbob commented 4 months ago

I first pasted it into Faction chat to show that it works there.

Terif1 commented 4 months ago

This will be fixed when we next push nations

subbob commented 3 months ago

Could be coincidental, but I mentioned GPS in alliance chat "I will send you GPS via DM" and my client immediately unloaded. (Lesson learned, I will NOT use that acronym in alliance chat for now) lol

Terif1 commented 3 months ago

yeah, sounds about right

Terif1 commented 3 months ago

The parser basically looks for "GPS" in severe chat message and if it finds it, it tries to extract a gps from it

Terif1 commented 3 months ago

Even as simple as "Gps" would be safe

subbob commented 3 months ago

Yea, immediately after posting this I wrote in game alliance chat. Do not use G P S (without spaces) in chat. 'cause I did not want to assume it was case sensitive, figured it was, but not willing another D/C to test it

subbob commented 3 months ago

image At this point could we just REMOVE the parser from Alliance chat?

Not just for me, but for the untold number of players that may be getting force unloaded and don't know why. https://discord.com/channels/516135382191177728/917984542432833566/1198342488109359114

Terif1 commented 3 months ago

Did I not push the fix to it?

Terif1 commented 3 months ago

Crap I didnt

Terif1 commented 3 months ago

It's fixed on git just needs someone to push it

subbob commented 3 months ago

Thanks.

Synirrr commented 3 months ago

Have we pushed this fix? If so we should close this

Terif1 commented 3 months ago

I think so

Terif1 commented 3 months ago

closing as fixed