DragWx / vsc-astronomy-theme

A straightforward warm/neutral/cool theme for Visual Studio Code
MIT License
1 stars 0 forks source link

Investigate semantic highlighting #4

Closed DragWx closed 3 years ago

DragWx commented 4 years ago

https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview https://code.visualstudio.com/updates/v1_43#_typescript-semantic-highlighting

I'm not sure if this will create any differences with how the theme already works, but double check just to be sure.

The apparent weakness of textmate is that many tokens get identified as variables, and it relies on the presence of hints like () for functions, etc, in order to clarify what the token actually is.

I was originally looking for equations to have minimal coloring, functions to have light logic color, and classes.with.many.nested.members to only have the leaf member colored.

I haven't looked yet, but I'm anticipating the semantic highlighting to cause many of the tokens to be colorized whereas they weren't before.

DragWx commented 3 years ago

5c0e5acc935c082b4be2c63766d848c622cf3648 counts as investigation, right?

I noticed that classes with nested properties now have all properties colored instead of just the leaf, but I think I'm fine with that if it means better stuff in the future.