search

Draggon / hassio-hdd-tools

27 stars 12 forks source link

Specify a device type #51

Closed eroldan closed 1 year ago

eroldan commented 2 years ago

In reference to issue #50

McGiverGim commented 2 years ago

I don't know if maybe it's better to add simply an "extra parameters" that can work with any parameter/s, and use the device type as example in the documentation. Has smartctl other parameters that can be useful?

eroldan commented 2 years ago

Having a generic field is something that I thought about but could not find any other useful parameter in my use cases. I think that hdd_path and device_type will cover 99% of usage. Still is doable to add a generic field later if there is need from users. It's your call. Thank for reviewing this.

hubikj commented 1 year ago

Hello, any chance this will be merged? I suffer from the same issue, while smartctl --all -d sntjmicron /dev/sda works for me. Thanks!

McGiverGim commented 1 year ago

@eroldan are you interested about finishing this?

eroldan commented 1 year ago

Hi @McGiverGim ,

I think the current state works for me and probably other users. I don't have much time now. I recommend you to just merge and do modifications to your preferences. I still use this addon. Thanks!

McGiverGim commented 1 year ago

Ok, I can't merge it directly because the conflict, it needs a rebase, but I will modify it to merge.