search

DragoNext / AqwDoIhave

Chrome Extension that shows if you have item on aqwiki
MIT License
8 stars 3 forks source link

Merge Shop wrong More Details position, also one bugs with it. #10

Open DragoNext opened 1 year ago

DragoNext commented 1 year ago

Need to fix position so it is before the text not after it (It Makes it look worse) From: image To: image

Icon that is from Bank Or Inventory Should Be on right as i consider it as Tag not As More Details.

Fix: Doesn't properly display shop name. image

Performance of it: Is it slow as it is gets data in real time, in future it will be improved as it will use scraped data.

Quannh1511 commented 1 year ago

Good idea, I am very important about performance, hope you have a solution to improve the logic of the code. It should be threaded and look easy to read.

DragoNext commented 1 year ago

Fixed positions of Icon, now will work on code to use scraped data to index items details, instead of making request to aqwiki and scrapping it in real time, it should improve performance tremendously. image

Quannh1511 commented 1 year ago

For now I think the icon section might be fine, but for me I won't recognize the new icon, but instead display it in text and change the color to a different color from the color of the wiki item to make it easier to visualize.

Quannh1511 commented 1 year ago

Here is my illustrative example. If possible, you can make the filter display as text or icon. image

Quannh1511 commented 1 year ago

Hello, I'm back. I need your information from Discord. It would be easier for us to talk there.