search

DragonBe / vies

Component using the European Commission (EC) VAT Information Exchange System (VIES) to verify and validate VAT registration numbers in the EU, using PHP and Composer.
http://ec.europa.eu/taxation_customs/vies/faqvies.do#item16
MIT License
266 stars 59 forks source link

VIES_EU_COUNTRY_LIST Visibility #120

Closed blaaat closed 3 years ago

blaaat commented 3 years ago

VIES_EU_COUNTRY_LISTis a protected const, but all other code is using self::VIES_EU_COUNTRY_LIST.

the protected visibility gives the illusion you can extend the class and for example remove UK (#98 ), but this wouldn't work.

VIES_EU_COUNTRY_LIST should either be private or beter; other methods should use: static::VIES_EU_COUNTRY_LIST

DragonBe commented 3 years ago

Not going to make them static