DragonBe / vies

Component using the European Commission (EC) VAT Information Exchange System (VIES) to verify and validate VAT registration numbers in the EU, using PHP and Composer.
http://ec.europa.eu/taxation_customs/vies/faqvies.do#item16
MIT License
266 stars 59 forks source link

Remove incorrect LV 1st digit check #147

Open cheagerty-ledger opened 2 years ago

cheagerty-ledger commented 2 years ago

Hello, here is my proposed change to solve the problem discussed in Issue 146. It removes a 1st-digit check that I believe is inaccurate.

(This is my first open source software contributing, so be gentle!) :-)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

iamniels commented 1 year ago

There seems to be more to this: https://gist.github.com/svschannak/e79892f4fbc56df15bdb5496d0e67b85#file-vat_validation-js-L984

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud