search

DragonCherry / AssetsPickerViewController

Powerfully Customizable - Multiple Photo & Video Picker Controller
MIT License
388 stars 136 forks source link

Album performance optimization #86

Closed gezihuzi closed 4 years ago

gezihuzi commented 4 years ago

Optimize the internal method of fetchAlbums(forAlbumType type:( to fetch resources only for the default albums using the synchronous method, other albums are fetched asynchronously. This method is not perfect yet, but it has been tested and it works, all that needs to be done now is to update the album list view synchronously when the album information is fetched. I need more people to help me to improve this part of the code or to provide suggestions. Thank you very much.

https://github.com/DragonCherry/AssetsPickerViewController/issues/62

gezihuzi commented 4 years ago

After this and previous optimizations, now the albums will load and speed in UI display will be much faster than before, after testing. In iPhone 8, iOS 13.6.1, 87898 photos, 1054 videos, the loading time is 3~5s, there are still some problems at this stage, because in addition to the default albums, other albums load asynchronously, which will lead to missing data when viewing all albums, at this time you need to update the data set and UI synchronously when the asynchronous task is complete.

gezihuzi commented 4 years ago

Hi @DragonCherry , I sent you an email with this optimization related question, if you see this comment, please reply to me via email. Thanks.

DragonCherry commented 4 years ago

Hello gezihuzi!

You can contact me via this email anytime. I'm sorry in advance for late response. (I had to look into changes you made these days but I couldn't)

Thank you!

      1. 오후 8:14, gezihuzi notifications@github.com :

 Hi @DragonCherry , I sent you an email with this optimization related question, if you see this comment, please reply to me via email. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.