search

DragonFixes / moremobheads-1.13-datapack

This is a revamped version of Xisuma's More Mob Heads datapack that works on 1.13+ servers and clients.
GNU General Public License v3.0
0 stars 5 forks source link

Not working in 18w20c #1

Open bugmancx opened 6 years ago

bugmancx commented 6 years ago

I've tested this in the latest snapshot and it it will not work.

I noted that it is activated by having a crafting bench so after installing it on a fresh world:

  1. Confirm the datapack is installed correctly: /datapack list

  2. Summon evocation_illager (has a 100% drop rate) /summon minecraft:evocation_illager

  3. Kill the mob

At this point a mob head should drop but doesn't. I have also tested by going around killing mobs randomly with a Looting 100 sword but haven't seen any heads drop.

Checking the code it looks like the included functions are activated via the advancement tree by the player having held a crafting_bench, so I tried that as well but sadly, it didn't make any difference.

carlpoole commented 6 years ago

I noticed that the illager names changed recently, I think its now minecraft:evoker

But I tried with the zombie horse which has a 100% drop rate, and it still doesn't work. I am happy to help fix this, will try and see if I can figure it out. If anyone else has any ideas what to do but don't have the time to look into it, let me know and I will play with it.

carlpoole commented 6 years ago

Update: I got this working in 1.13-pre5 since my comment two hours ago. I had to add an entities directory in between loot_tables and all the json files. this seemed to get the heads to start dropping. I also fixed the names of the illagers to the new evoker and vindicator minecraft names and they were dropping too.

Despite this, the names of the heads were showing as Player Head so I went and tweaked the loot table so instead of this:

{ "function": "set_nbt", "tag": "{display:{LocName:\"Zombie Horse Head\"},SkullOwner:{Id:\"ab9ea02c-4fd1-4895-85c9-d2b407d5d6f2\",Properties:{textures:[{Value:\"eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvZDIyOTUwZjJkM2VmZGRiMThkZTg2ZjhmNTVhYzUxOGRjZTczZjEyYTZlMGY4NjM2ZDU1MWQ4ZWI0ODBjZWVjIn19fQ==\"}]}}}" }

I modified it to this, and the correct name showed on the head:

"functions": [ { "function": "set_nbt", "tag": "{SkullOwner:{Id:\"ab9ea02c-4fd1-4895-85c9-d2b407d5d6f2\",Properties:{textures:[{Value:\"eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvZDIyOTUwZjJkM2VmZGRiMThkZTg2ZjhmNTVhYzUxOGRjZTczZjEyYTZlMGY4NjM2ZDU1MWQ4ZWI0ODBjZWVjIn19fQ==\"}]}}}" }, { "function": "set_name", "name": "Zombie Horse Head" } ]

I will probably go through and fix them all over the next day or so and a pull request and link a current working copy.

carlpoole commented 6 years ago

If anyone is still trying to get this to work check out my pull request and fork: https://github.com/xNitrate/moremobheads-1.13-datapack/pull/2